updated races.h preview

[uRit1u2CBBA=]

Below is the diff file for races.h that I generated. (Basically, all new lines are appended to the bottom of the file, if you want to do it yourself manually before it gets into cvs)

338,339c338,359
<
<
---
>     "Troll - Broken Skull",   // 331
>     "Troll - Broken Skull",   // 332
>     NULL,                     // 333
>     NULL,                     // 334
>     NULL,                     // 335
>     NULL,                     // 336
>     NULL,                     // 337
>     "Gnome - Broken Skull",   // 338
>     "Dark Elf - Broken Skull",// 339
>     "Ogre - Broken Skull",    // 340
>     "Human - Broken Skull",   // 341
>     "Erudite - Broken Skull", // 342
>     NULL,                     // 343
>     "Zombie - Broken Skull",  // 344
>     "Luggald",                // 345
>     "Luggald",                // 346
>     "Luggald",                // 347
>     "Drogmor",                // 348
>     NULL,                     // 349
>     NULL,                     // 350
>     "Dark Elf - Hate",        // 351
>     "Dark Elf - Hate",        // 352

After making the change to the races.h file, I just did a make ; make install , no need to re-configure.

I didn't know if you wanted the "Broken Skull" or "Hate" information in here or not. If people think that it shouldn't belong, I'll remove them before posting the patch. If it sounds like people don't care either way, I'll leave them in.

Please post your thoughts if you want the labels modified or left alone.

Thanks

[Mr. Suspicious]

The race_id's in reaces.h match up to the bane_dmg_race value on items.

So if an item has a bane_dmg_race of (example) 217 then it does Bane Damage to a mob that has a race_id of 217. 217 = "Shissar". On the item ingame, it doesn't state the number, but the name of the race, in this case: "Shissar".

I personally think it's best to follow the "ingame naming convention" as much as possible. So basically: everything is fine by me, as long as the naming is updated as soon as we know the _exact_ name of the race of the mob.

You also might try to find the differences to the various same named races in your list: is it gender? alignment? This might help to identify the different races even better.

[uRit1u2CBBA=]

I initially thought that each gender would have a different race number, but a male troll and a female troll can each have a 332, etc.

The 2 Dark Elves in hate - 351 are armored (warrior, etc.) elves, and 352 are robed (wizard, etc.) elves. Either could be male or female.

[Mr. Suspicious]

In that case I'd change (by lack of the exact name)

> "Dark Elf Armored - Hate", // 351
> "Dark Elf Robed - Hate", // 352

Personally I'd also change all the NULL values like:

> NULL, // 333

to

> Unknown 333, // 333

That way it's easier to spot still unknown races in the display by creating an alert on Race:Unknown

Just my personal opinions, nothing official =)

[uRit1u2CBBA=]

I'd say that would be a good idea, except for that the way it works now, if string is NULL, it shows the number already, so it would make things a little more difficult having to sort bottom up (and not always be the bottom), vs. sorting top down (and it will be the top) to spot unknown races.

[Mr. Suspicious]

You're right, better keep them NULL then.