Longer title/suffix strings is not the cause of the crash, increasing the field length is just masking the problem by stopping seq from crashing. Something else is wrong.
Longer title/suffix strings is not the cause of the crash, increasing the field length is just masking the problem by stopping seq from crashing. Something else is wrong.
Looks like it's being caused by a player with charProperties = 0
here's the fix, spawnshell.cpp, line 613:
edit: fixed the fix
Code:if(i == 0) { spawn->bodytype = 0; } else { do { nTmp = netStream.readUInt32NC(); if(i == spawn->charProperties) { spawn->bodytype = nTmp; #ifdef FILLSPAWNSTRUCT_DIAG seqDebug("bodytype = %d", spawn->bodytype); #endif } } while(--i); }
Last edited by showeq42; 01-24-2013 at 03:57 AM.
I reverted the increased lengths in everquest.h and added your fix to spawnshell.cpp. Zoned into Field of Scale and no crash. Tonight I will be able to verify if this has any impact on the disconnect.
Does this get added at line 613 or replace the code that is there?Originally Posted by showeq42
line 613 is "do" and replacing there didn't work for me. It's early so maybe I am just being dense...Code:i = spawn->charProperties; do { nTmp = netStream.readUInt32NC(); if(i == spawn->charProperties) { spawn->bodytype = nTmp; #ifdef FILLSPAWNSTRUCT_DIAG seqDebug("bodytype = %d", spawn->bodytype); #endif } } while(--i);
diff against unpatched showeq-5.13.10.10
Code:*** spawnshell.cpp.0 2013-01-13 15:59:33.000000000 -0800 --- spawnshell.cpp 2013-01-24 03:29:29.007054064 -0800 *************** *** 611,627 **** i = spawn->charProperties; ! do { ! nTmp = netStream.readUInt32NC(); ! if(i == spawn->charProperties) ! { ! spawn->bodytype = nTmp; #ifdef FILLSPAWNSTRUCT_DIAG ! seqDebug("bodytype = %d", spawn->bodytype); #endif ! } } - while(--i); spawn->curHp = netStream.readUInt8(); --- 611,634 ---- i = spawn->charProperties; ! if(i == 0) { ! spawn->bodytype = 0; ! } ! else ! { ! do ! { ! nTmp = netStream.readUInt32NC(); ! if(i == spawn->charProperties) ! { ! spawn->bodytype = nTmp; #ifdef FILLSPAWNSTRUCT_DIAG ! seqDebug("bodytype = %d", spawn->bodytype); #endif ! } ! } ! while(--i); } spawn->curHp = netStream.readUInt8(); *************** *** 883,887 **** if (dir != DIR_Client) { ! int16_t y = (pupdate->y + pupdate->y) >> 3; int16_t x = pupdate->x >> 3; int16_t z = pupdate->z >> 3; --- 890,894 ---- if (dir != DIR_Client) { ! int16_t y = pupdate->y >> 3; int16_t x = pupdate->x >> 3; int16_t z = pupdate->z >> 3;
Here is the patch up to now based on everything I have collected from this thread.
Code:Index: conf/zoneopcodes.xml =================================================================== --- conf/zoneopcodes.xml (revision 783) +++ conf/zoneopcodes.xml (working copy) @@ -3,231 +3,231 @@ <seqopcodes> <!-- Critical opcodes used directly by ShowEQ --> - <opcode id="46bb" name="OP_PlayerProfile" updated="12/12/12"> + <opcode id="5772" name="OP_PlayerProfile" updated="01/16/13"> <comment>CharProfileCode</comment> <payload dir="server" typename="uint8_t" sizechecktype="none"/> </opcode> - <opcode id="1665" name="OP_ZoneEntry" updated="12/12/12"> + <opcode id="60a8" name="OP_ZoneEntry" updated="01/16/13"> <comment>ZoneEntryCode</comment> <payload dir="client" typename="ClientZoneEntryStruct" sizechecktype="match"/> <payload dir="server" typename="uint8_t" sizechecktype="none"/> </opcode> - <opcode id="3be2" name="OP_TimeOfDay" updated="12/12/12"> + <opcode id="5824" name="OP_TimeOfDay" updated="01/16/13"> <comment>TimeOfDayCode</comment> <payload dir="server" typename="timeOfDayStruct" sizechecktype="match"/> </opcode> - <opcode id="7fff" name="OP_NewZone" updated="12/12/12"> + <opcode id="18cd" name="OP_NewZone" updated="01/16/13"> <comment>NewZoneCode</comment> <payload dir="server" typename="newZoneStruct" sizechecktype="match"/> </opcode> - <opcode id="7b6c" name="OP_SpawnDoor" updated="12/12/12"> + <opcode id="31ed" name="OP_SpawnDoor" updated="01/16/13"> <comment>DoorSpawnsCode</comment> <payload dir="server" typename="doorStruct" sizechecktype="modulus"/> </opcode> - <opcode id="4286" name="OP_GroundSpawn" updated="12/12/12"> + <opcode id="56b2" name="OP_GroundSpawn" updated="01/16/13"> <comment>MakeDropCode</comment> <payload dir="server" typename="makeDropStruct" sizechecktype="none"/> <payload dir="client" typename="uint8_t" sizechecktype="none"/> </opcode> - <opcode id="7922" name="OP_SendZonePoints" updated="12/12/12"> + <opcode id="0d72" name="OP_SendZonePoints" updated="01/16/13"> <comment>Coords in a zone that will port you to another zone</comment> <payload dir="server" typename="zonePointsStruct" sizechecktype="none"/> </opcode> - <opcode id="25C5" name="OP_AAExpUpdate" updated="12/12/12"> + <opcode id="4212" name="OP_AAExpUpdate" updated="01/16/13"> <comment>Receiving AA experience. Also when percent to AA changes.</comment> <payload dir="server" typename="altExpUpdateStruct" sizechecktype="match"/> </opcode> - <opcode id="47E3" name="OP_ExpUpdate" updated="12/12/12"> + <opcode id="4ecc" name="OP_ExpUpdate" updated="01/16/13"> <comment>ExpUpdateCode</comment> <payload dir="server" typename="expUpdateStruct" sizechecktype="match"/> </opcode> - <opcode id="0561" name="OP_GuildMOTD" updated="12/12/12"> + <opcode id="5531" name="OP_GuildMOTD" updated="01/16/13"> <comment>GuildMOTD</comment> <payload dir="server" typename="guildMOTDStruct" sizechecktype="none"/> </opcode> - <opcode id="455d" name="OP_ClientUpdate" updated="12/12/12"> - <comment>Position updates - looks to be 455d and 42 bytes as of 12/12/12</comment> + <opcode id="0be5" name="OP_ClientUpdate" updated="01/16/13"> + <comment>Position updates</comment> <payload dir="server" typename="playerSpawnPosStruct" sizechecktype="match"/> <payload dir="both" typename="playerSelfPosStruct" sizechecktype="match"/> </opcode> - <opcode id="5BD9" name="OP_NpcMoveUpdate" updated="12/12/12"> + <opcode id="4788" name="OP_NpcMoveUpdate" updated="01/16/13"> <comment>Position updates</comment> <payload dir="server" typename="uint8_t" sizechecktype="none"/> </opcode> - <opcode id="6b5a" name="OP_MobUpdate" updated="12/12/12"> + <opcode id="142c" name="OP_MobUpdate" updated="01/16/13"> <comment>MobUpdateCode</comment> <payload dir="both" typename="spawnPositionUpdate" sizechecktype="match"/> </opcode> - <opcode id="3c8e" name="OP_DeleteSpawn" updated="12/12/12"> + <opcode id="4234" name="OP_DeleteSpawn" updated="01/16/13"> <comment>DeleteSpawnCode</comment> <payload dir="both" typename="deleteSpawnStruct" sizechecktype="match"/> </opcode> - <opcode id="3B06" name="OP_RemoveSpawn" updated="12/12/12"> + <opcode id="781f" name="OP_RemoveSpawn" updated="01/16/13"> <comment>Remove spawn from zone</comment> <payload dir="both" typename="removeSpawnStruct" sizechecktype="none"/> </opcode> - <opcode id="3a65" name="OP_Death" updated="12/12/12"> + <opcode id="2c22" name="OP_Death" updated="01/16/13"> <comment>old NewCorpseCode</comment> <payload dir="server" typename="newCorpseStruct" sizechecktype="match"/> </opcode> - <opcode id="1ad3" name="OP_WearChange" updated="12/12/12"> + <opcode id="32fb" name="OP_WearChange" updated="01/16/13"> <comment>SpawnUpdateCode</comment> <payload dir="both" typename="SpawnUpdateStruct" sizechecktype="match"/> </opcode> - <opcode id="7360" name="OP_SpawnAppearance" updated="12/12/12"> + <opcode id="201a" name="OP_SpawnAppearance" updated="01/16/13"> <comment>SpawnAppearanceCode</comment> <payload dir="both" typename="spawnAppearanceStruct" sizechecktype="match"/> </opcode> - <opcode id="1949" name="OP_Stamina" updated="12/12/12"> + <opcode id="4932" name="OP_Stamina" updated="01/16/13"> <comment>Server updating on hunger/thirst</comment> <payload dir="server" typename="staminaStruct" sizechecktype="match"/> </opcode> - <opcode id="07b8" name="OP_HPUpdate" updated="12/12/12"> + <opcode id="65e7" name="OP_HPUpdate" updated="01/16/13"> <comment>NpcHpUpdateCode Update HP % of a PC or NPC</comment> <payload dir="both" typename="hpNpcUpdateStruct" sizechecktype="match"/> </opcode> - <opcode id="0048" name="OP_GuildMemberUpdate" updated="12/12/12"> + <opcode id="24da" name="OP_GuildMemberUpdate" updated="01/16/13"> <comment>Info regarding guild members</comment> <payload dir="server" typename="GuildMemberUpdate" sizechecktype="match"/> </opcode> - <opcode id="7992" name="OP_ClickObject" updated="12/12/12"> + <opcode id="607d" name="OP_ClickObject" updated="01/16/13"> <comment>Items dropped on the ground</comment> <payload dir="both" typename="remDropStruct" sizechecktype="match"/> </opcode> - <opcode id="0ea7" name="OP_Action" updated="12/12/12"> + <opcode id="31b6" name="OP_Action" updated="01/16/13"> <comment>Spells cast etc</comment> <payload dir="both" typename="actionStruct" sizechecktype="match"/> <payload dir="both" typename="actionAltStruct" sizechecktype="match"/> </opcode> - <opcode id="5428" name="OP_Action2" updated="12/12/12"> + <opcode id="4598" name="OP_Action2" updated="01/16/13"> <comment>Combat actions i.e. bash, kick etc</comment> <payload dir="both" typename="action2Struct" sizechecktype="match"/> </opcode> - <opcode id="4d8d" name="OP_Consider" updated="12/12/12"> + <opcode id="1184" name="OP_Consider" updated="01/16/13"> <comment>ConsiderCode</comment> <payload dir="both" typename="considerStruct" sizechecktype="match"/> </opcode> - <opcode id="0e25" name="OP_TargetMouse" updated="12/12/12"> + <opcode id="0a2d" name="OP_TargetMouse" updated="01/16/13"> <comment>Targeting a person - old ClientTargetCode</comment> <payload dir="both" typename="clientTargetStruct" sizechecktype="match"/> </opcode> - <opcode id="5040" name="OP_SpawnRename" updated="12/12/12"> + <opcode id="72c5" name="OP_SpawnRename" updated="01/16/13"> <comment>Spawns getting renamed after initial NewSpawn</comment> <payload dir="server" typename="spawnRenameStruct" sizechecktype="match"/> </opcode> - <opcode id="6C43" name="OP_Illusion" updated="12/12/12"> + <opcode id="02e6" name="OP_Illusion" updated="01/16/13"> <comment>Spawn being illusioned (changing forms)</comment> <payload dir="both" typename="spawnIllusionStruct" sizechecktype="match"/> </opcode> - <opcode id="0747" name="OP_Shroud" updated="12/12/12"> + <opcode id="3223" name="OP_Shroud" updated="01/16/13"> <comment>Server putting players into shroud form</comment> <payload dir="server" typename="spawnShroudSelf" sizechecktype="none"/> </opcode> - <opcode id="1EB4" name="OP_ZoneChange" updated="12/12/12"> + <opcode id="1eb4" name="OP_ZoneChange" updated="12/12/12"> <comment>old ZoneChangeCode</comment> <payload dir="both" typename="zoneChangeStruct" sizechecktype="match"/> </opcode> - <opcode id="1602" name="OP_GroupInvite" updated="12/12/12"> + <opcode id="3877" name="OP_GroupInvite" updated="01/16/13"> <payload dir="both" typename="groupInviteStruct" sizechecktype="none"/> <comment>You invite someone while ungrouped or get invited by someone ungrouped </comment> </opcode> - <opcode id="6E80" name="OP_GroupInvite2" updated="12/12/12"> + <opcode id="4b77" name="OP_GroupInvite2" updated="01/16/13"> <payload dir="client" typename="groupInviteStruct" sizechecktype="none"/> <comment>You're inviting someone and you are grouped or get invited by a group</comment> </opcode> - <opcode id="2B26" name="OP_GroupCancelInvite" updated="12/12/12"> + <opcode id="1afc" name="OP_GroupCancelInvite" updated="01/16/13"> <payload dir="both" typename="groupDeclineStruct" sizechecktype="match"/> <comment>Declining to join a group</comment> </opcode> - <opcode id="0BA4" name="OP_GroupFollow" updated="12/12/12"> + <opcode id="35cc" name="OP_GroupFollow" updated="01/16/13"> <payload dir="server" typename="groupFollowStruct" sizechecktype="match"/> <comment>You join a group or player joins group</comment> </opcode> - <opcode id="5FAE" name="OP_GroupFollow2" updated="12/12/12"> + <opcode id="5fae" name="OP_GroupFollow2" updated="12/12/12"> <payload dir="server" typename="groupFollowStruct" sizechecktype="match"/> <comment>Player joins your group</comment> </opcode> - <opcode id="5A07" name="OP_GroupUpdate" updated="12/12/12"> - <comment>Group member names - Variable length</comment> + <opcode id="7056" name="OP_GroupUpdate" updated="01/16/13"> + <comment>Group updates</comment> <payload dir="both" typename="uint8_t" sizechecktype="none"/> </opcode> - <opcode id="623D" name="OP_GroupDisband" updated="12/12/12"> + <opcode id="559d" name="OP_GroupDisband" updated="01/16/13"> <comment>You disband from group</comment> <payload dir="server" typename="groupDisbandStruct" sizechecktype="match"/> </opcode> - <opcode id="74FA" name="OP_GroupDisband2" updated="12/12/12"> + <opcode id="7862" name="OP_GroupDisband2" updated="01/16/13"> <comment>Other disbands from group</comment> <payload dir="server" typename="groupDisbandStruct" sizechecktype="match"/> </opcode> - <opcode id="46FC" name="OP_GroupLeader" updated="12/12/12"> + <opcode id="07d8" name="OP_GroupLeader" updated="01/16/13"> <comment>Group leader change</comment> <payload dir="server" typename="groupLeaderChangeStruct" sizechecktype="match"/> </opcode> - <opcode id="08ED" name="OP_Buff" updated="12/12/12"> + <opcode id="08ed" name="OP_Buff" updated="12/12/12"> <comment>old BuffDropCode</comment> <payload dir="both" typename="buffStruct" sizechecktype="match"/> </opcode> - <opcode id="41cb" name="OP_BuffFadeMsg" updated="12/12/12"> + <opcode id="193a" name="OP_BuffFadeMsg" updated="01/16/13"> <comment>SpellFadeCode</comment> <payload dir="both" typename="spellFadedStruct" sizechecktype="none"/> </opcode> - <opcode id="17FF" name="OP_BeginCast" updated="12/12/12"> + <opcode id="7ec6" name="OP_BeginCast" updated="01/16/13"> <comment>BeginCastCode</comment> <payload dir="both" typename="beginCastStruct" sizechecktype="match"/> </opcode> - <opcode id="1cb5" name="OP_CastSpell" updated="12/12/12"> + <opcode id="6bd3" name="OP_CastSpell" updated="01/16/13"> <comment>StartCastCode</comment> <payload dir="both" typename="startCastStruct" sizechecktype="match"/> </opcode> - <opcode id="4736" name="OP_SwapSpell" updated="12/12/12"> + <opcode id="30c2" name="OP_SwapSpell" updated="01/16/13"> <comment>TradeSpellBookSlotsCode</comment> <payload dir="both" typename="tradeSpellBookSlotsStruct" sizechecktype="match"/> </opcode> - <opcode id="2FAC" name="OP_MemorizeSpell" updated="12/12/12"> + <opcode id="72a0" name="OP_MemorizeSpell" updated="01/16/13"> <comment>MemSpellCode</comment> <payload dir="both" typename="memSpellStruct" sizechecktype="match"/> </opcode> - <opcode id="5794" name="OP_InspectAnswer" updated="12/12/12"> + <opcode id="3d94" name="OP_InspectAnswer" updated="01/16/13"> <comment>InspectDataCode</comment> <payload dir="both" typename="inspectDataStruct" sizechecktype="match"/> </opcode> - <opcode id="37FD" name="OP_Emote" updated="12/12/12"> + <opcode id="50d6" name="OP_Emote" updated="01/16/13"> <comment>EmoteTextCode</comment> <payload dir="both" typename="emoteTextStruct" sizechecktype="none"/> </opcode> - <opcode id="02A5" name="OP_SimpleMessage" updated="12/12/12"> + <opcode id="4926" name="OP_SimpleMessage" updated="01/16/13"> <comment>SimpleMessageCode</comment> <payload dir="server" typename="simpleMessageStruct" sizechecktype="match"/> </opcode> - <opcode id="6AFE" name="OP_FormattedMessage" updated="12/12/12"> + <opcode id="1bc4" name="OP_FormattedMessage" updated="01/16/13"> <comment>FormattedMessageCode i.e. pet dismissed etc</comment> <payload dir="server" typename="formattedMessageStruct" sizechecktype="none"/> </opcode> - <opcode id="33BC" name="OP_CommonMessage" updated="12/12/12"> + <opcode id="7aba" name="OP_CommonMessage" updated="01/16/13"> <comment>ChannelMessageCode i.e. /tell /ooc /shout etc</comment> <payload dir="both" typename="channelMessageStruct" sizechecktype="none"/> </opcode> - <opcode id="362C" name="OP_SpecialMesg" updated="12/12/12"> + <opcode id="7d26" name="OP_SpecialMesg" updated="01/16/13"> <comment>Communicate textual info to client including hail responses etc</comment> <payload dir="server" typename="specialMessageStruct" sizechecktype="none"/> </opcode> - <opcode id="59DB" name="OP_RandomReq" updated="12/12/12"> + <opcode id="5d57" name="OP_RandomReq" updated="01/16/13"> <comment>RandomReqCode</comment> <payload dir="client" typename="randomReqStruct" sizechecktype="match"/> </opcode> - <opcode id="6525" name="OP_RandomReply" updated="12/12/12"> + <opcode id="0b4b" name="OP_RandomReply" updated="01/16/13"> <comment>RandomCode</comment> <payload dir="server" typename="randomStruct" sizechecktype="match"/> </opcode> - <opcode id="183D" name="OP_ConsentResponse" updated="12/12/12"> + <opcode id="183d" name="OP_ConsentResponse" updated="12/12/12"> <comment>Server replying with consent information after /consent</comment> <payload dir="server" typename="consentResponseStruct" sizechecktype="match"/> </opcode> - <opcode id="344A" name="OP_DenyResponse" updated="12/12/12"> + <opcode id="344a" name="OP_DenyResponse" updated="12/12/12"> <comment>Server replying with deny information after /deny</comment> <payload dir="server" typename="consentResponseStruct" sizechecktype="match"/> </opcode> - <opcode id="1E3B" name="OP_ManaChange" updated="12/12/12"> + <opcode id="7d4d" name="OP_ManaChange" updated="01/16/13"> <comment>Mana change. Bards send this up with no size. Casters receive this for mana updates.</comment> <payload dir="server" typename="manaDecrementStruct" sizechecktype="match"/> <payload dir="client" typename="uint8_t" sizechecktype="none"/> @@ -242,15 +242,15 @@ <comment>MoneyOnCorpseCode</comment> <payload dir="server" typename="moneyOnCorpseStruct" sizechecktype="match"/> </opcode> - <opcode id="52C6" name="OP_SkillUpdate" updated="12/12/12"> + <opcode id="52c6" name="OP_SkillUpdate" updated="12/12/12"> <comment>Skill up code</comment> <payload dir="server" typename="skillIncStruct" sizechecktype="match"/> </opcode> - <opcode id="7CE0" name="OP_LevelUpdate" updated="12/12/12"> + <opcode id="7ce0" name="OP_LevelUpdate" updated="12/12/12"> <comment>LevelUpUpdateCode - causing crashes as of 12/08/12 Investigating</comment> <payload dir="server" typename="levelUpUpdateStruct" sizechecktype="match"/> </opcode> - <opcode id="5437" name="OP_CorpseLocResponse" updated="12/12/12"> + <opcode id="0000" name="OP_CorpseLocResponse" updated="12/12/12"> <comment>old CorpseLocCode:</comment> <payload dir="server" typename="corpseLocStruct" sizechecktype="match"/> </opcode> @@ -258,7 +258,7 @@ <comment></comment> <payload dir="server" typename="none" sizechecktype="match"/> </opcode> - <opcode id="0e01" name="OP_DzSwitchInfo" updated="12/12/12"> + <opcode id="331d" name="OP_DzSwitchInfo" updated="01/16/13"> <comment>Expedition compass etc</comment> <payload dir="server" typename="dzSwitchInfo" sizechecktype="none"/> </opcode> @@ -268,7 +268,7 @@ </opcode> <!-- Not necessary for SEQ to run but here to name packets in logs. --> - <opcode id="7a19" name="OP_MovementHistory" updated="12/12/12"> + <opcode id="62d2" name="OP_MovementHistory" updated="01/16/13"> <comment>Movement history for speed/movement hack detection</comment> <payload dir="client" typename="uint8_t" sizechecktype="none"/> </opcode> @@ -297,7 +297,7 @@ <payload dir="server" typename="itemInfoStruct" sizechecktype="none"/> <payload dir="client" typename="itemInfoReqStruct" sizechecktype="none"/> </opcode> - <opcode id="28a9" name="OP_EnvDamage" updated="11/28/12"> + <opcode id="0518" name="OP_EnvDamage" updated="01/16/13"> <comment>Environmental Damage</comment> <payload dir="client" typename="environmentDamageStruct" sizechecktype="match"/> </opcode> @@ -305,23 +305,23 @@ <comment>old cRunToggleCode</comment> <payload dir="client" typename="cRunToggleStruct" sizechecktype="match"/> </opcode> - <opcode id="71f5" name="OP_UIUpdate" updated="12/12/12"> + <opcode id="1cc2" name="OP_UIUpdate" updated="01/16/13"> <comment>Seems to be sent to handle a variety of UI updates - Variable length</comment> <payload dir="server" typename="unknown" sizechecktype="none"/> </opcode> - <opcode id="1aae" name="OP_GroupMemberList" updated="08/17/12"> + <opcode id="2aca" name="OP_GroupMemberList" updated="01/16/13"> <comment>List of group members - Variable length</comment> <payload dir="server" typename="unknown" sizechecktype="none"/> </opcode> - <opcode id="4053" name="OP_GuildMemberList" updated="12/12/12"> + <opcode id="183b" name="OP_GuildMemberList" updated="01/16/13"> <comment>List of guild members - Variable length</comment> <payload dir="server" typename="uint8_t" sizechecktype="none"/> </opcode> - <opcode id="6675" name="OP_ManaUpdate" updated="12/12/12"> + <opcode id="089f" name="OP_ManaUpdate" updated="01/16/13"> <comment>Mana Update opcode - 10 bytes</comment> <payload dir="server" typename="unknown" sizechecktype="none"/> </opcode> - <opcode id="71fb" name="OP_EndUpdate" updated="12/12/12"> + <opcode id="3a7c" name="OP_EndUpdate" updated="01/16/13"> <comment>Endurance Update opcode - 10 bytes</comment> <payload dir="server" typename="unknown" sizechecktype="none"/> </opcode> @@ -341,7 +341,7 @@ <comment>Fellowship campfire information - 1076 bytes</comment> <payload dir="client" typename="unknown" sizechecktype="none"/> </opcode> - <opcode id="3c4b" name="OP_SelectCampfire" updated="11/28/12"> + <opcode id="7802" name="OP_SelectCampfire" updated="01/16/13"> <comment>Fellowship campfire Choices - Guessing variable length</comment> <payload dir="server" typename="unknown" sizechecktype="none"/> </opcode> @@ -349,19 +349,19 @@ <comment>Contents of claims window. /claim then refresh to capture packet - Guessing variable length</comment> <payload dir="server" typename="unknown" sizechecktype="none"/> </opcode> - <opcode id="3bcc" name="OP_VoiceChat" updated="12/12/12"> + <opcode id="2640" name="OP_VoiceChat" updated="01/16/13"> <comment>Voice chat server info - Variable length (Data sent when joining group,raid etc)</comment> <payload dir="server" typename="unknown" sizechecktype="none"/> </opcode> - <opcode id="6e6c" name="OP_PollQuestions" updated="12/12/12"> + <opcode id="6e09" name="OP_PollQuestions" updated="01/16/13"> <comment>SOE in-game player poll questions - Variable length</comment> <payload dir="both" typename="unknown" sizechecktype="none"/> </opcode> - <opcode id="17ee" name="OP_PollResponses" updated="12/12/12"> + <opcode id="7ad7" name="OP_PollResponses" updated="01/16/13"> <comment>Poll response choices - Variable length</comment> <payload dir="server" typename="unknown" sizechecktype="none"/> </opcode> - <opcode id="7251" name="OP_ShroudProgression" updated="12/12/12"> + <opcode id="25a2" name="OP_ShroudProgression" updated="01/16/13"> <comment>Unlocked shrouds - 244 bytes</comment> <payload dir="server" typename="unknown" sizechecktype="none"/> </opcode> @@ -369,15 +369,15 @@ <comment>Shroud templates to choose from on shroud NPC - 18983 bytes</comment> <payload dir="server" typename="unknown" sizechecktype="none"/> </opcode> - <opcode id="40fd" name="OP_Fellowship" updated="12/12/12"> + <opcode id="7ae9" name="OP_Fellowship" updated="01/16/13"> <comment>Fellowship information - 2564 bytes</comment> <payload dir="server" typename="unknown" sizechecktype="none"/> </opcode> - <opcode id="7851" name="OP_ExpandedGuildInfo" updated="12/12/12"> + <opcode id="11b1" name="OP_ExpandedGuildInfo" updated="01/16/13"> <comment>Guild ranks and other misc guild data - Variable length</comment> <payload dir="server" typename="unknown" sizechecktype="none"/> </opcode> - <opcode id="1cbf" name="OP_GuildBank" updated="12/12/12"> + <opcode id="34d3" name="OP_GuildBank" updated="01/16/13"> <comment>Guild bank contents - Guessing variable length</comment> <payload dir="server" typename="unknown" sizechecktype="none"/> </opcode> @@ -401,23 +401,23 @@ <comment>Tradeskill combine using old tradeskill window - 24 Bytes</comment> <payload dir="both" typename="uint8_t" sizechecktype="none"/> </opcode> - <opcode id="786e" name="OP_ItemPlayerPacket" updated="12/12/12"> + <opcode id="44db" name="OP_ItemPlayerPacket" updated="01/16/13"> <comment>Inventory/bank items coming over during zone - Variable length</comment> <payload dir="both" typename="uint8_t" sizechecktype="none"/> </opcode> - <opcode id="2294" name="OP_TaskDescription" updated="12/12/12"> + <opcode id="5c2a" name="OP_TaskDescription" updated="01/16/13"> <comment>Task descriptions coming down for task window - Variable length</comment> <payload dir="server" typename="unknown" sizechecktype="none"/> </opcode> - <opcode id="7181" name="OP_TaskActivity" updated="12/12/12"> + <opcode id="902b" name="OP_TaskActivity" updated="01/16/13"> <comment>Task activity descriptions coming down for task window - Variable length</comment> <payload dir="server" typename="unknown" sizechecktype="none"/> </opcode> - <opcode id="9495" name="OP_CompletedTasks" updated="12/12/12"> + <opcode id="2a6f" name="OP_CompletedTasks" updated="01/16/13"> <comment>Task history for task window - Variable length</comment> <payload dir="server" typename="unknown" sizechecktype="none"/> </opcode> - <opcode id="471a" name="OP_CustomTitles" updated="12/12/12"> + <opcode id="26eb" name="OP_CustomTitles" updated="01/16/13"> <comment>List of available titles - 1520 bytes</comment> <payload dir="server" typename="unknown" sizechecktype="none"/> </opcode> @@ -533,7 +533,7 @@ <comment>Client side raid invite requests 140 bytes</comment> <payload dir="client" typename="unknown" sizechecktype="none"/> </opcode> - <opcode id="5dcf" name="OP_RaidJoin" updated="11/28/12"> + <opcode id="3ab1" name="OP_RaidJoin" updated="01/16/13"> <comment>Server side raid information - Variable length</comment> <payload dir="server" typename="unknown" sizechecktype="none"/> </opcode> @@ -553,7 +553,7 @@ <comment>LFG/LFP server response - Variable length</comment> <payload dir="server" typename="unknown" sizechecktype="none"/> </opcode> - <opcode id="5a7c" name="OP_MercenaryList" updated="12/12/12"> + <opcode id="27a5" name="OP_MercenaryList" updated="01/16/13"> <comment>Listing of hired mercenaries - 429 bytes <payload dir="server" typename="unknown" sizechecktype="none"/></comment> </opcode> @@ -573,11 +573,11 @@ <comment>Client clicks off buff - 8 bytes</comment> <payload dir="client" typename="unknown" sizechecktype="none"/> </opcode> - <opcode id="6786" name="OP_HouseAddress" updated="12/12/12"> + <opcode id="3bf6" name="OP_HouseAddress" updated="01/16/13"> <comment>House and guildhall address information - Variable length</comment> <payload dir="server" typename="unknown" sizechecktype="none"/> </opcode> - <opcode id="7cda" name="OP_HouseContents" updated="11/28/12"> + <opcode id="222f" name="OP_HouseContents" updated="01/16/13"> <comment>Server sending house information and contents - variable length</comment> <payload dir="server" typename="unknown" sizechecktype="none"/> </opcode> @@ -593,11 +593,11 @@ <comment>Server sending pending rewards - variable length</comment> <payload dir="both" typename="unknown" sizechecktype="none"/> </opcode> - <opcode id="63ae" name="OP_FTPNags" updated="12/12/12"> + <opcode id="1874" name="OP_FTPNags" updated="01/16/13"> <comment>Free to play nags and other data - 1852 bytes</comment> <payload dir="server" typename="unknown" sizechecktype="none"/> </opcode> - <opcode id="34c3" name="OP_Find" updated="12/12/12"> + <opcode id="5de1" name="OP_Find" updated="01/16/13"> <comment>Find window data - 112 bytes</comment> <payload dir="server" typename="unknown" sizechecktype="none"/> </opcode> @@ -612,15 +612,15 @@ <!-- Below are used to help make sense of the logs when searching for opcodes Using these marks unknown opcodes in logs for easier reading --> - <opcode id="218d" name="OP_Unknown1" updated="12/12/12"> + <opcode id="05c3" name="OP_Unknown1" updated="01/16/13"> <comment>3 byte opcode that spam logs seemingly only when you have someone targeted. Marked here to make reading logs easier</comment> <payload dir="server" typename="unknown" sizechecktype="none"/> </opcode> - <opcode id="48b5" name="OP_Unknown2" updated="12/12/12"> + <opcode id="7d71" name="OP_Unknown2" updated="01/16/13"> <comment>3 byte opcode that spam logs seemingly only when you have someone targeted. Marked here to make reading logs easier</comment> <payload dir="server" typename="unknown" sizechecktype="none"/> </opcode> - <opcode id="7cb5" name="OP_Unknown3" updated="12/12/12"> + <opcode id="68a5" name="OP_Unknown3" updated="01/16/13"> <comment>3 byte opcode that spam logs seemingly only when you have someone targeted. Marked here to make reading logs easier</comment> <payload dir="server" typename="unknown" sizechecktype="none"/> </opcode> Index: src/spawnshell.cpp =================================================================== --- src/spawnshell.cpp (revision 783) +++ src/spawnshell.cpp (working copy) @@ -610,19 +610,26 @@ #endif i = spawn->charProperties; - do + if(i == 0) + { + spawn->bodytype = 0; + } + else { - nTmp = netStream.readUInt32NC(); + do + { + nTmp = netStream.readUInt32NC(); - if(i == spawn->charProperties) - { - spawn->bodytype = nTmp; + if(i == spawn->charProperties) + { + spawn->bodytype = nTmp; #ifdef FILLSPAWNSTRUCT_DIAG - seqDebug("bodytype = %d", spawn->bodytype); + seqDebug("bodytype = %d", spawn->bodytype); #endif - } + } + } + while(--i); } - while(--i); spawn->curHp = netStream.readUInt8(); #ifdef FILLSPAWNSTRUCT_DIAG @@ -882,7 +889,7 @@ if (dir != DIR_Client) { - int16_t y = (pupdate->y + pupdate->y) >> 3; + int16_t y = pupdate->y >> 3; int16_t x = pupdate->x >> 3; int16_t z = pupdate->z >> 3; Index: src/player.h =================================================================== --- src/player.h (revision 783) +++ src/player.h (working copy) @@ -21,7 +21,7 @@ //---------------------------------------------------------------------- // constants -const int maxSpawnLevel = 100; +const int maxSpawnLevel = 255; enum ColorLevel { Index: src/spawn.cpp =================================================================== --- src/spawn.cpp (revision 783) +++ src/spawn.cpp (working copy) @@ -418,7 +418,7 @@ { setName(s->name); setLastName(s->lastName); - setPos(s->x >> 3, (s->y + s->y) >> 3, s->z >> 3); + setPos(s->x >> 3, s->y >> 3, s->z >> 3); setPetOwnerID(s->petOwnerId); setLight(s->light); setGender(s->gender); Index: src/everquest.h =================================================================== --- src/everquest.h (revision 783) +++ src/everquest.h (working copy) @@ -1076,23 +1076,24 @@ { struct { - signed padding0004:13; - signed y:19; // y coord - - signed deltaX:13; // change in x - signed deltaHeading:10;// change in heading - signed padding0008:9; - - signed deltaY:13; // change in y - signed z:19; // z coord - - signed x:19; // x coord - signed animation:10; // animation - signed padding0016:3; - - unsigned heading:12; // heading - signed deltaZ:13; // change in z - signed padding0020:7; + signed padding0004:12; + signed deltaZ:13; // change in z + signed padding00042:7; + + signed deltaHeading:10;// change in heading + signed x:19; // x coord + signed padding0008:3; + + unsigned heading:12; // heading + signed deltaY:13; // change in y + signed padding0012:7; + + signed deltaX:13; // change in x + signed y:19; // y coord + + signed animation:10; // animation + signed z:19; // z coord + signed padding0020:3; }; int32_t posData[5]; }; @@ -2339,19 +2340,20 @@ { /*0000*/ uint16_t spawnId; /*0002*/ uint16_t spawnId2; -/*0004*/ signed padding0004:13; +/*0004*/ unsigned pitch:12; + signed deltaZ:13; // change in z + unsigned padding01:7; +/*0008*/ signed deltaHeading:10;// change in heading + signed x:19; // x coord + unsigned padding02:3; +/*0012*/ unsigned heading:12; // heading + signed deltaY:13; // change in y + unsigned padding03:7; +/*0016*/ signed deltaX:13; // change in x signed y:19; // y coord -/*0008*/ signed deltaX:13; // change in x - signed deltaHeading:10;// change in heading - signed padding0008:9; -/*0012*/ signed deltaY:13; // change in y +/*0020*/ signed animation:10; // velocity signed z:19; // z coord -/*0016*/ signed x:19; // x coord - signed animation:10; // animation - signed padding0016:3; -/*0020*/ unsigned heading:12; // heading - signed deltaZ:13; // change in z - signed padding0020:7; + unsigned padding04:3; /*0024*/ }; @@ -2363,21 +2365,24 @@ struct playerSelfPosStruct { -/*0000*/ uint8_t unknown0000[2]; // ***Placeholder (update time counter?) +/*0000*/ uint16_t unknown0000; // ***Placeholder (update time counter?) /*0002*/ uint16_t spawnId; // Player's spawn id -/*0004*/ uint8_t unknown0004[6]; // ***Placeholder -- BSH 13 Apr 2011 -/*0010*/ float deltaY; // Change in x -/*0014*/ float x; // x coord (1st loc value) -/*0018*/ float y; // y coord (2nd loc value) +/*0004*/ uint16_t unknown0004; // ***Placeholder +/*0006*/ unsigned pitch:12; // pitch (up/down heading) + unsigned heading:12; // Directional heading + unsigned padding1:8; // ***Placeholder +/*0010*/ float y; // y coord (2nd loc value) +/*0014*/ float deltaZ; // Change in z +/*0018*/ float z; // z coord (3rd loc value) /*0022*/ signed deltaHeading:10; // change in heading - unsigned animation:10; // animation - unsigned padding0024:12; // ***Placeholder -/*0026*/ float deltaZ; // Change in z + unsigned padding2:10; // ***Placeholder + unsigned padding3:12; // ***Placeholder +/*0026*/ float x; // x coord (1st loc value) /*0030*/ float deltaX; // Change in y -/*0034*/ float z; // z coord (3rd loc value) -/*0038*/ unsigned heading:12; // Directional heading - unsigned padding0040:10; // ***Placeholder - unsigned padding0041:10; // ***Placeholder +/*0034*/ float deltaY; // Change in x +/*0038*/ signed animation:10; // velocity + unsigned padding4:10; // ***Placeholder + unsigned padding5:12; // ***Placeholder /*0042*/ };
Still have the random disconnects. I thought maybe I'd see a problem in zone.log, but nothing looks obvious. I was standing in a zone, not moving and it disconnected. A couple days ago I was grouped with another ShowEQ user in the same zone killing the same stuff. We both had the disconnects, but at completely different times.
Here is the end of the console output thought I'm not sure how old some of the lines are:
Seems like it think I zoned or camped, but I didn't. zoning or camping will fix it though.Code:Warning: EQPacket: Unhandled net opcode c800, stream client-zone, size 106 Warning: EQPacket: Unhandled net opcode 0000, stream zone-client, size 2 Debug: PCAP Filter Set: udp[0:2] > 1024 and udp[2:2] > 1024 and ether proto 0x0800 and host 192.168.0.115 Info: EQPacket: SessionDisconnect detected, awaiting next zone session, pcap filter: EQ Client 192.168.0.115
Is there any log I could enable to maybe catch what is causing this.
I wonder if it's related to the unhandled opcode 0000. I didn't see it in the zone log anywhere, maybe it doesn't get logged. But there's many opcodes set to 0000 in zoneopcodes.xml. One of them is OP_RequestZoneChange. It may be that if the packet size is correct that it's randomly picking up this unhandled 0000 as one of these undefined zone changes. I modified all the 0000 opcodes to be a random value instead that seems to not be used, FFDF. Will see if that has any impact.
Last edited by ShortBuss; 01-24-2013 at 08:11 PM.
Turn on some of the protocol #defines so you can see session operations. That sure looks like something is triggering a session handler for a session disconnect. It could be random network traffic. It could be something else.
You guys shouldn't use 0000 as a garbage opcode. Opcodes that end in 00 I think trigger 3 byte opcodes.
I think I finally found the cause. I enabled global log and that is helping me see more details. Looks like ShowEQ is picking up my mumble traffic and firing on it sometimes. Digging through the code I found that 0x500 opcode is session disconnect. And right at the time of my last packets in zone log I see a 0x500 opcode picked up going mumble server -> my client.
I hid the IP, but here's what it looks like. This log is about 100ms after my last zone log entry.
So now I just need to figure out a way to block my mumble server IP address from being ready by ShowEQ.Code:Jan 24 2013 22:21:40:311 [<My Mumble Server IP>:7506->client:58368] [Size: 110] [OPCode: 0x500] 000 | 00 05 61 99 9b 7a da 72 6e e5 42 90 e7 90 88 87 | ..a..z.rn.B..... 016 | 86 d8 95 87 0e 81 e6 a0 59 48 b7 19 95 10 ef c4 | ........YH...... 032 | 66 79 c2 23 c6 e2 62 b9 33 97 c0 6a c2 49 cf b4 | fy.#..b.3..j.I.. 048 | 1e 02 05 6d 33 6c a8 c8 c6 5d 05 0c e3 39 19 fc | ...m3l...]...9.. 064 | f4 e1 5f 21 e1 c7 fb 61 a7 3a 84 01 a0 86 f0 c7 | .._!...a.:...... 080 | 57 3c b3 ea fe 9b f5 29 83 fa 90 18 23 cc 52 e0 | W<.....)....#.R. 096 | af bf 36 07 39 df 6f a3 1c ee 42 46 d3 af | ..6.9.o...BF..
Seems there's no easy way outside of modifying the code to filter out specific IPs or ports. If there is then I missed it. I modified the pcap filters in packetcapture.cpp to ignore the port, 7506, and a couple of the IPs related to the mumble server. This should at least prevent the false disconnect (0x0500). Unfortunately it means I will be applying a custom patch on top of any built, but that's not a big issue. I see other bad traffic being looked at, like itunes for example, but I'll leave it alone as long as it doesn't cause any problems.
This is what session tracking is for. Turn it on. It should automatically lock the pcap filter tighter for you.
Thanks, I will give session tracking another try. I thought I had tried before and still had the disconnect, but I may be confusing it with the seg faults that are fixed.
Pardon me if I am suggesting something that's either been tried, painfully obvious or way off base, but have you tried session tracking within SEQ? I recall that for some it was an effective way to ignore unecessary network traffic.
I turned Session Tracking on again, but for some reason even with it on I'm still seeing mumble traffic being processed by ShowEQ. It could be something to do with my setup. I'm running EQ on Windows (of course). I'm running ShowEQ on Linux from within a VirtualBox VM on the same system as EQ. The VirtualBox network is setup as Bridged and Promiscuous mode set to all.
There are currently 1 users browsing this thread. (0 members and 1 guests)
Posting Permissions
Reply With Quote