Bug: Casting Eye of Zomm (from items) Causes Crash

[Showmo]

ShowEQ Version:
ShowEQ 6.3.9, Built from 'main.cpp' on Dec 7 2023 at 06:38:38
CVS: @(#) $Id: main.cpp 1279 2022-10-20 00:33:52Z cn187 $ $Name$
Using GCC version: 9.4.0
Using glibc version: 2.31
Using Qt version: 4.8.7
Running on Linux release 5.4.0-166-generic for processor x86_64


Error upon crash:

Info: - SpellItem 'Eye of Zomm' finished.
Info: - Your player's id is 21455
Info: - Your player's id is 21425
malloc(): mismatching next->prev_size (unsorted)
Aborted




How to reproduce: Cast Eye of Zomm from items: Crystalline Orb or Ocular Scout Control Unit

Not a mage, so I cant test from just the spell itself, but its the same spell across the items and player spell

Let me know if anyone needs more information

[cn187]

Somehow I missed this when it was posted - sorry about that.

Thanks for reporting this.

[Showmo]

Somehow I missed this when it was posted - sorry about that.

Thanks for reporting this.

No worries, I know time is valuable Let me know if I can provide any more information. I tried tracking it down and all I learned was my C is VERY rusty.

[cn187]

OK, I may have a patch for this.

At least, it fixes the crash, and a related issue that showed up after the crash was resolved.

But I'm a little concerned the fix may break something else if a particular edge case exists. So I need to do some more testing before I apply it to trunk.

In the mean time, if you'd like to try it out, I've attached the patch. It's generated from git, so apply it with -p1 instead of the usual -p0.

Edit: OK, I tested and fixed the main edge case I thought of, and I've updated the patch to the latest version of the fix. There could still be unexpected fallout, so I'm hoping we can test it a bit (with or without actually using Eye of Zomm, etc.) just to make sure other things haven't broken as a result.

Edit: Updated to v4 to handle some other related issues.

[Showmo]

My apologies. Life's been kinda busy. I've applied the patch, recompiled and tested the clickies and everything looks good so far. I'll keep running around and look for anything out of the ordinary and report back if I find anything.

You are a rocket star

[Showmo]

Checking again, been running this patch and its been rock solid. I havent seen any abnormalities.

[cn187]

Awesome. Thanks for the update!

[cn187]

Found another related issue - while there was no crashing and the player was showing on the map correctly, the player was showing as "unknown" in the spawnlist. This should be fixed now, and hopefully it didn't affect the other parts of the fix (I did some rudimentary testing, and it seems OK).

The patch above has been updated to v4. Apply with -p1