PDA

View Full Version : 10 21 09 Patch



Mano
10-22-2009, 04:11 PM
It appears there was changes to structures (particulary npcMoveUpdate).

From what I can determine the npcMoveUpdate struct is now 16bytes as opposed to 8.

With my limited experience I have tracked down the following opcodes

292F - OP_NpcMoveUpdate
4B61 - OP_ZoneEntry (This alone gets skittles again...kind of)
0C2B - OP_InspectAnswer
59A8 - OP_GroupFollow2
3C2D - OP_Consider
47AE - OP_ItemPlayerPacket
156C - OP_TaskDescription
31FE - OP_TaskActivity
03AE - OP_CompletedTasks
7BF6 - OP_CustomTitles

Is there anyone working this? I have tried to increase the size of npcMoveUpdate to uint16_t but simply changing the function def in the .h and .cpp files is giving me compile errors related to BitStream that I don't understand.

ieatacid
10-22-2009, 05:05 PM
There's a thread about this patch here (http://www.showeq.net/forums/showthread.php?t=6346) (it's mis-titled).

I'm only missing a few that I'll get when I log in shortly.

--> Diff (http://www.ieatacid.com/20091021a.txt)

ieatacid
10-22-2009, 06:38 PM
Updated the diff in my previous post.

It seems to be working fine for me. If anyone gets any errors, please post here.

ieatacid
10-22-2009, 06:41 PM
Also, npcMoveUpdate is variable in size. The function in the client that handles this didn't change, so ShowEQ should still work correctly without modification.

Backspace
10-22-2009, 09:45 PM
Patched the diff and all looks good so far. Will post any problems I come across.

plaisance
10-23-2009, 01:28 AM
Updated the diff in my previous post.

It seems to be working fine for me. If anyone gets any errors, please post here.

only looking to confirm if there is a syntax issue with the diff as I am getting a hunk 1 of 2 at 102.

@@ -102,65 +102,65 @@
<payload dir="server" typename="groupInviteStruct" sizechecktype="match"/>
<comment>You got invited to a group</comment>
</opcode>-->
I was able to patch around it with a manual edit, but hopefully you could share what i was possibly doing wrong to have the patch fail at the above location?

ieatacid
10-23-2009, 02:16 PM
only looking to confirm if there is a syntax issue with the diff as I am getting a hunk 1 of 2 at 102.

@@ -102,65 +102,65 @@
<payload dir="server" typename="groupInviteStruct" sizechecktype="match"/>
<comment>You got invited to a group</comment>
</opcode>-->
I was able to patch around it with a manual edit, but hopefully you could share what i was possibly doing wrong to have the patch fail at the above location?

I don't know why the svn diff came out that way, but you could try replacing the line

@@ -102,65 +102,65 @@

with

<!--<opcode id="5251" name="OP_GroupInvited" updated="09/15/09">

plaisance
10-23-2009, 04:56 PM
I don't know why the svn diff came out that way, but you could try replacing the line

@@ -102,65 +102,65 @@
with

<!--<opcode id="5251" name="OP_GroupInvited" updated="09/15/09">


Thanks Ieatacid! :)

That was the manual edit I performed and so far, no crashes or other issues to report.

Greatly appreciate you taking the time to provide the diff as well as others who play on test in an attempt to stay a day ahead of 'potential' changes.